Skip to content

[FIX] Normalize: Integer variable representation #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 21, 2020

Issue

When copying a variable, number_of_decimals is copied along with other variable properties, causing the normalized integer variable being represented as an integer.

Description of changes

Override number_of_decimals, when copying a variable.

Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT force-pushed the fix_normalize_n_dec branch from 1765ed5 to e4c6479 Compare January 21, 2020 14:12
@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #4350 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4350      +/-   ##
==========================================
+ Coverage   86.91%   86.97%   +0.06%     
==========================================
  Files         396      396              
  Lines       71991    72147     +156     
==========================================
+ Hits        62571    62753     +182     
+ Misses       9420     9394      -26

@janezd janezd self-assigned this Jan 24, 2020
When copying a variable, number_of_decimals is copied along with other variable properties, causing the normalized integer variable being represented as an integer.
@VesnaT VesnaT force-pushed the fix_normalize_n_dec branch from e4c6479 to 3f8bc1b Compare January 24, 2020 10:23
@janezd janezd merged commit d9edad9 into biolab:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants