Skip to content

Conversation

@aturanjanin
Copy link
Contributor

Description of changes

Modification of the status bar data info display.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #4547 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4547      +/-   ##
==========================================
+ Coverage   83.37%   83.53%   +0.16%     
==========================================
  Files         279      276       -3     
  Lines       55779    55303     -476     
==========================================
- Hits        46507    46199     -308     
+ Misses       9272     9104     -168     

@aturanjanin aturanjanin force-pushed the owoutliers branch 3 times, most recently from 5bd2e85 to fda42c1 Compare March 18, 2020 18:24
@aturanjanin aturanjanin changed the title [ENH] OWOutliers: Data info displayed in the status bar [WIP] OWOutliers: Data info displayed in the status bar Mar 18, 2020
@aturanjanin aturanjanin force-pushed the owoutliers branch 2 times, most recently from 676d7f5 to 6331696 Compare March 19, 2020 16:37
@aturanjanin aturanjanin changed the title [WIP] OWOutliers: Data info displayed in the status bar [ENH] OWOutliers: Data info displayed in the status bar Mar 19, 2020
info = self.widget.info
data = self.iris
input_sum = self.widget.info.set_input_summary = Mock()
output_sum = self.widget.info.set_output_summary = Mock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not much point in self.assertEqual(info._StateInfo__input_summary.brief, "") lines, since self.widget.info.set_input_summary was mocked.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for the code some lines below.
info._StateInfo__input_summary.brief could never have been changed, since mocked, so there is no point of testing it.

You could leave the test as it was, just add the lines to test the detail:
self.assertEqual(info._StateInfo__input_summary.detail, detail)

info = self.widget.info
data = self.iris
input_sum = self.widget.info.set_input_summary = Mock()
output_sum = self.widget.info.set_output_summary = Mock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for the code some lines below.
info._StateInfo__input_summary.brief could never have been changed, since mocked, so there is no point of testing it.

You could leave the test as it was, just add the lines to test the detail:
self.assertEqual(info._StateInfo__input_summary.detail, detail)

@aturanjanin aturanjanin force-pushed the owoutliers branch 3 times, most recently from db40e92 to 4fb67e1 Compare March 23, 2020 13:19
@VesnaT VesnaT merged commit 68c8445 into biolab:master Mar 23, 2020
@aturanjanin aturanjanin deleted the owoutliers branch March 30, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants