-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[ENH] OWOutliers: Data info displayed in the status bar #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4547 +/- ##
==========================================
+ Coverage 83.37% 83.53% +0.16%
==========================================
Files 279 276 -3
Lines 55779 55303 -476
==========================================
- Hits 46507 46199 -308
+ Misses 9272 9104 -168 |
5bd2e85 to
fda42c1
Compare
676d7f5 to
6331696
Compare
| info = self.widget.info | ||
| data = self.iris | ||
| input_sum = self.widget.info.set_input_summary = Mock() | ||
| output_sum = self.widget.info.set_output_summary = Mock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not much point in self.assertEqual(info._StateInfo__input_summary.brief, "") lines, since self.widget.info.set_input_summary was mocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same goes for the code some lines below.
info._StateInfo__input_summary.brief could never have been changed, since mocked, so there is no point of testing it.
You could leave the test as it was, just add the lines to test the detail:
self.assertEqual(info._StateInfo__input_summary.detail, detail)
| info = self.widget.info | ||
| data = self.iris | ||
| input_sum = self.widget.info.set_input_summary = Mock() | ||
| output_sum = self.widget.info.set_output_summary = Mock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same goes for the code some lines below.
info._StateInfo__input_summary.brief could never have been changed, since mocked, so there is no point of testing it.
You could leave the test as it was, just add the lines to test the detail:
self.assertEqual(info._StateInfo__input_summary.detail, detail)
db40e92 to
4fb67e1
Compare
Description of changes
Modification of the status bar data info display.
Includes