Skip to content

Conversation

@PrimozGodec
Copy link
Contributor

Issue

Fixes #4599

Description of changes

Fixing merge data when missing values in data.

Includes
  • Code changes
  • Tests

@PrimozGodec PrimozGodec changed the title OWEditDomain: fix merge variables when missing data [FIX] OWEditDomain: Fix merge values when missing data Apr 9, 2020
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #4636 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4636      +/-   ##
==========================================
- Coverage   83.64%   83.64%   -0.01%     
==========================================
  Files         281      276       -5     
  Lines       56271    55470     -801     
==========================================
- Hits        47070    46397     -673     
+ Misses       9201     9073     -128     

@janezd
Copy link
Contributor

janezd commented Apr 9, 2020

Now it works for me. @ajdapretnar, can you also check and then merge?

@lanzagar lanzagar changed the title [FIX] OWEditDomain: Fix merge values when missing data [FIX] Edit Domain: Fix merge values when missing data Apr 10, 2020
@ajdapretnar ajdapretnar merged commit 54282c8 into biolab:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit Domain: merge less frequent values crashes

3 participants