Skip to content

[FIX] owheatmap: Fix assertion error when restoring selection #5517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janezd merged 1 commit into from
Jul 27, 2021
Merged

[FIX] owheatmap: Fix assertion error when restoring selection #5517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Orange/widgets/visualize/owheatmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,8 @@ def is_variable(obj):

self.update_heatmaps()
if data is not None and self.__pending_selection is not None:
assert self.scene.widget is not None
self.scene.widget.selectRows(self.__pending_selection)
if self.scene.widget is not None:
self.scene.widget.selectRows(self.__pending_selection)
self.selected_rows = self.__pending_selection
self.__pending_selection = None

Expand Down
14 changes: 14 additions & 0 deletions Orange/widgets/visualize/tests/test_owheatmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,20 @@ def test_saved_selection(self):
self.send_signal(w.Inputs.data, iris, widget=w)
self.assertEqual(len(self.get_output(w.Outputs.selected_data)), 21)

def test_saved_selection_when_not_possible(self):
# Has stored selection but ot enough columns for clustering.
iris = Table("iris")[:, ["petal width"]]
w = self.create_widget(
OWHeatMap, stored_settings={
"__version__": 3,
"col_clustering_method": "Clustering",
"selected_rows": [1, 2, 3],
}
)
self.send_signal(w.Inputs.data, iris)
out = self.get_output(w.Outputs.selected_data)
self.assertSequenceEqual(list(out.ids), list(iris.ids[[1, 2, 3]]))

def test_set_split_var(self):
data = self.brown_selected[::3]
w = self.widget
Expand Down