-
Notifications
You must be signed in to change notification settings - Fork 83
Added association for environmental process association - issue #1560 #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| minimum_cardinality: 2 | ||
| conditioned by qualifier: | ||
| description: >- | ||
| This property applies to the qualified association and either upregulates or downregulates it. It can accept any combination of 0 to 2 state variables and processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious how this relates to the regulates predicate:
biolink-model/biolink-model.yaml
Line 2820 in ac34f0b
| regulates: |
and the
upregulated direction qualifier? Would you happen to have an example eenvironmental process association with all fields filled out that I can look at? (or in paragraph form/plain text)
| range: molecular entity | ||
|
|
||
| eenvironmental process association: | ||
| is_a: association |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the extra "e" here meaningful?
| - process context qualifier | ||
| - conditioned by qualifier | ||
| - ecosystem context qualifier | ||
| slot_usage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the detail notes here, they really help!
| in_subset: | ||
| - ecolink | ||
|
|
||
| conditioned by qualifier: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add some examples here - I am not quite sure I fully understand what "conditioned by" means?
- can it have a value of [
upregulates,downregulates] in one record? - how does it relate to the direction qualifier suite (the enumeration for this qualifier has values
upregulatedanddownregulated). - how does it relate to the
regulatespredicate?
Maybe the necessity of this slot means we should think about breaking the association into two edges? I'm not sure; maybe an example would help?
| description: >- | ||
| Sample/biosample datamodel | ||
| ecolink: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that we have a ecolink linkml schema, maybe we can change the subsets to mappings? :)
sierra-moxon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
more examples on the PR or in the schema itself would be helpful for the "conditioned by" slot.
-
it would be lovely to change the subset to a series of mappings for each new component (to the ecolink schema).
-
possibly typo in association name
Thank you for the detailed and informative association class! Its very well done.
First draft of
environmental process associationfor discussion and to be added to Biolink Model.