-
Notifications
You must be signed in to change notification settings - Fork 7
Fix flaky WPS provider responses (i.e.: other WPS birds) causing failure during their registration in weaver
#321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1501/Result : success BIRDHOUSE_DEPLOY_BRANCH : fix-flaky-wps-provider-standalone DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-92.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1090/NOTEBOOK TEST RESULTS |
tlvu
approved these changes
Apr 20, 2023
Collaborator
tlvu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1506/Result : failure BIRDHOUSE_DEPLOY_BRANCH : fix-flaky-wps-provider-standalone DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-92.rdext.crim.ca Infrastructure deployment failed. Instance has not been destroyed. @matprov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/operations
Continuous Integration components
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix flaky WPS provider responses (i.e.: other WPS birds) causing failure during their registration in
weaver.Changes
Non-breaking changes
Fix flaky WPS provider responses (i.e.: other WPS birds) causing failure during their registration in
weaver.In some cases, the WPS birds would not respond properly when starting the stack, either because they are still
initiating or due to other temporary failures such as services being restarted until healthy. This fix introduces
a retry mechanism to attempt WPS registration in
weaverup toWEAVER_WPS_PROVIDERS_RETRY_COUNT=5times(1 initial attempt + 5 retries), and with
WEAVER_WPS_PROVIDERS_RETRY_AFTER=5second intervals between each retry.If the maximum number of retries for any WPS provider or the
WEAVER_WPS_PROVIDERS_MAX_TIMEacross all registrationsare reached, the operation is aborted.
Breaking changes
Related Issue / Discussion
fix-canarieapias base branch) instead ofmaster(this PR)