-
Notifications
You must be signed in to change notification settings - Fork 7
allow custom cors headers for stac #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7c2a5a9
d1b9f73
aae7483
5369091
8da406a
942cc07
2aa0cae
7d21fd9
b1c62a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.18.9 2025-11-10T17:14:06Z | ||
| 2.18.10 2025-11-12T17:25:51Z |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| config/magpie/config.yml | ||
| config/proxy/conf.extra-service.d/stac.conf | ||
| config/proxy/conf.extra-directives.d/stac.conf | ||
| config/canarie-api/canarie_api_monitoring.py | ||
| service-config.json |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| map $http_origin $stac_origin_allowed { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remind me what the Nginx This block means if the
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's mostly right... This block creates a new variable |
||
| # default should not be set to the empty string because the cors.include file will interpret | ||
| # that as "unset" and will change it to * by default. To get around this, set this to birdhouse's | ||
| # own origin (which has the same effect as being unset since same-origin requests are already allowed). | ||
| default ${BIRDHOUSE_PROXY_SCHEME}://${BIRDHOUSE_FQDN_PUBLIC}; | ||
| ${STAC_ADDITIONAL_CORS_ORIGINS} | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"STAC Browser is not protected by any authorization mechanism", this part is not true anymore, that's why it is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's technically true but it's misleading. Access to the stac-browser endpoint is not checked by twitcher but if the user doesn't have permissions to read the stac data (because the stac endpoint is protected by twitcher) then the stac-browser page shows a 403 error anyway.
So from the user's perspective it is protected by an authorization mechanism, it's the same one that protects the stac endpoint.