add BIRDHOUSE_PROXY_CORS_ALLOW_ORIGIN setting
#611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3837/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : add-cors-origin DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-216.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/546/NOTEBOOK TEST RESULTS |
tlvu
requested changes
Nov 27, 2025
Collaborator
tlvu
left a comment
tlvu
left a comment
There was a problem hiding this comment.
A few minor changes requested but looks good otherwise.
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3846/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : add-cors-origin DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-216.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/551/NOTEBOOK TEST RESULTS |
mishaschwartz
requested changes
Dec 1, 2025
tlvu
requested changes
Dec 1, 2025
Collaborator
tlvu
left a comment
tlvu
left a comment
There was a problem hiding this comment.
Duplicate BIRDHOUSE_SSL_CERTIFICATE
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3855/Result 🆘 ABORTEDBIRDHOUSE_DEPLOY_BRANCH : add-cors-origin DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-91.rdext.crim.ca
|
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3854/Result 🆘 ABORTEDBIRDHOUSE_DEPLOY_BRANCH : add-cors-origin DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-91.rdext.crim.ca
|
mishaschwartz
requested changes
Dec 1, 2025
| if ( $access_control_allow_origin ~ "^$" ) { | ||
| set $access_control_allow_origin '*'; | ||
| } | ||
| # assumes that the server default is configured or overriden by a specific locaiton block as needed |
Collaborator
There was a problem hiding this comment.
Is this if block needed anymore?
Member
Author
There was a problem hiding this comment.
I think so because the value could still be set explicitly (or resolved from variable expansions) to ''.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add
BIRDHOUSE_PROXY_CORS_ALLOW_ORIGINsetting.Note
The
cors.include.templatediff looks massive, but the actual concrete change is only adding:Changes
Non-breaking changes
Access-Control-Allow-Originheader to be configured usingBIRDHOUSE_PROXY_CORS_ALLOW_ORIGINvariable.cors.includefile is converted to acors.include.templatefile to allow variable expansion.BIRDHOUSE_PROXY_CORS_ALLOW_ORIGIN="*"is used to retain the previous behaviour.BIRDHOUSE_PROXY_CORS_ALLOW_ORIGINvariable can reference other variables to allow dynamic configuration(notably, to reference
BIRDHOUSE_FQDN_PUBLICfor same-origin allowance).STAC_CORS_ORIGINSheader implications.access_control_allow_originvariable.Breaking changes
Related Issue / Discussion
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false