Skip to content

Conversation

@huard
Copy link
Contributor

@huard huard commented Apr 4, 2022

Overview

This PR fixes #191

Changes:

  • Added load method to WPS Execution response
  • Added load method to WPS Output objects according to the "best" converter found.

Related Issue / Discussion

This is still at the draft stage as a support for discussions.

Additional Information

Links to other issues or sources.

@huard
Copy link
Contributor Author

huard commented Apr 5, 2022

Hi @cehbrecht,

Here is a PR to discuss how to create a better interface for loading the data into python objects.

The way I'm doing this is that I'm "augmenting" the WPSExecution object with a load method, which returns BirdyOutput objects instead of owslib.wps.Output. Then each BirdyOutput is paired with a converter, which gives the BirdyOutput another load method that does the download and conversion.

I'm totally open to changing the names for these, and the interface.

@cehbrecht
Copy link
Member

@huard would you like to add a notebook example to see it in "action"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow keyword argument in get(asobj=True)

4 participants