-
Notifications
You must be signed in to change notification settings - Fork 5
Added a function for parsing AllowedValues #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Zeitsperre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering now whether the issue with the list of values is here or is deeper within OWSLib.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Hi, @Zeitsperre. I added some changes which addresses the issues you mentioned above. However, the tests are failing due to a ConnectionError. |
|
@RezwanM @Zeitsperre just come comments:
|
|
| The formatted docstring for this process. | ||
| """ | ||
| doc = [process.abstract or "", ""] | ||
| _process = wps.describeprocess(process.identifier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused why this is necessary. In my recollection, WPSClient._processes is a dict with the output of describeprocess, so isn't _process exactly the same as process ?
Overview
This PR fixes #277
Changes:
AllowedValues. The problem seemed to be that the attributeallowedValuesof theProcessDescriptionobject was being parsed byOWSLibas a Pythonset, which is inherently unordered. Parsing the elementAllowedValuesdirectly from raw XML into alistensures the original order of items inAllowedValuesis preserved.Related Issue / Discussion
Additional Information
Links to other issues or sources.