Skip to content

support birdhouse-deploy>=2.4.0 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mishaschwartz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support birdhouse-deploy>=2.4.0 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ Unreleased (latest)
Changes:
--------
- Add a config directory named `/jupyter_config_dir` to allow users to mount JupyterLab extension configuration.
- Discover the log directory using the `BIRDHOUSE_LOG_DIR` or the `PAVICS_LOG_DIR` environment variable in order to
support [birdhouse-deploy](https://github.com/bird-house/birdhouse-deploy/) versions >= 2.4.0

Fixes:
------
Expand Down
4 changes: 2 additions & 2 deletions scheduler-jobs/deploy_data_pavics_jupyter.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ for i in $( seq 1 "$(echo "${DOCKER_NOTEBOOK_IMAGES}" | wc -w)" ) ; do
return 1
fi

# Log file location. Default location under /var/log/PAVICS/ has built-in logrotate.
# Log file location. Default location under /var/log/birdhouse/ has built-in logrotate.
if [ -z "${DEPLOY_DATA_JOB_LOGFILE}" ]; then
DEPLOY_DATA_JOB_LOGFILE="${PAVICS_LOG_DIR}/${DEPLOY_DATA_JOB_JOB_NAME}.log"
DEPLOY_DATA_JOB_LOGFILE="${BIRDHOUSE_LOG_DIR:-${PAVICS_LOG_DIR}}/${DEPLOY_DATA_JOB_JOB_NAME}.log"
fi

if [ -z "$(echo "${AUTODEPLOY_EXTRA_SCHEDULER_JOBS}" | grep "${DEPLOY_DATA_JOB_JOB_NAME}")" ]; then
Expand Down