Skip to content

ros control should only publish joint states after the wait time is elapsed #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flova opened this issue Dec 12, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request lowlevel

Comments

@Flova
Copy link
Member

Flova commented Dec 12, 2024

Summary

Currently, joint states are published as soon as we get data from the motors. But we write data to the motors after a fixed delay to make sure they are fully booted. This delay should also apply for the publishing of data as otherwise there is a period of time where we get data from the motors (signaling to other parts of the software that they are available) but we can not control them yet. This is also related to the startup delay in the HCM which could be removed in this case. See #631 for the current approach.

@Flova Flova added the enhancement New feature or request label Dec 12, 2024
@Flova Flova added the lowlevel label Dec 12, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Software Dec 12, 2024
@Flova Flova moved this from 🆕 New to 📋 Backlog in Software Dec 12, 2024
@val-ba val-ba self-assigned this Apr 10, 2025
@val-ba val-ba moved this from 📋 Backlog to 🏗 In progress in Software Apr 10, 2025
@val-ba
Copy link
Contributor

val-ba commented Apr 17, 2025

Would you do that by just adding a bus_start_time_ condition as in wolfgang_hardware_interface.cpp in line 308, but just for the read method aswell? Isnt there other information which is also read over the bus? Should we wait for that aswell?

@Flova
Copy link
Member Author

Flova commented Apr 19, 2025

Ideally we should wait with everything. I am not 100% sure how I would implement this feature. I think it should be a few more lines tho .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lowlevel
Projects
Status: 🏗 In progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants