Add disk space display to status bar, Fixes #569

[tsenk]

Adds a free space label to the status bar, fixing #569. The label gets hidden when no backup path is configured. If the path is inaccessible, OSError gets caught and the label is hidden. Calculates free space using f_bavail for regular users and f_bfree in root mode. Units scale from B to TB.

[buhtz]

It seems you have not read any of the information intended to be for new contributors, so
please read this FAQ entries:

• Why do I need to introduce myself?
• Can you assign this to me?
• Can I use @ mentions freely in issues or PRs?
• Can I contribute without using the software?
• Can I boost my commit count?
• Can I submit AI-generated contributions?

[buhtz]

• Please provide a screenshot of the new GUI element.
• Did you run the unit tests? What are the results?

[buhtz]

AI slop and/or unmotivated student.

[tsenk]

Your first comment was a lazy dismissal. Please tell me which part you think is AI, Chris, that's not something you say lightly. I get how you might not like that it's not 100% ready to commit, but you could've left feedback for changes.

[buhtz]

Hello Torsten,

thank you for the feedback and thank you for sticking with this PR. 😄

Try to step into my shoes as upstream maintainer. As many other FOSS projects I am bombed and spamed with AI crap. Dealing with this makes you suspious about all kind of contribution. Is it AI or not? It sucks, but it is how it is! And I have to deal with my ressources. I can not dive into each PR in all details just do decide if it is AI or not. I need to find a balance between AI-diagnosis and resource efficency.

Based on my experience there are some indicators for AI contributions. In your case it was not obvious to me, that is why I did not closed it in the first place but waited some days. Concrete there where two indicators:

1. You did not read or did not understand/followed the CONTRIBUTING.md file. Because I was not sure abou the AI thing I tried to be kind and pointed you directly to related FAQ entries in hope you will respond appropriate.
2. No response to my comments.

that's not something you say lightly

That should be the case. But as I tried to explain it is a matter of balance. And im some cases my diagnosis is wrong.

you could've left feedback for changes.

Before I go into such details I need to know who is on the other side. And in your case it was not clear to me. So I needed to secure my resources.

Let's start again. Read the links I posted and please answere the questions I asked. Feel free to ask back if some things are not clear.

Regards,
Christian

EDIT: A minimum to read would have been this: https://github.com/bit-team/backintime/blob/dev/CONTRIBUTING.md#before-you-start Didn't you read that? What else should I add to motivate first-time-contributors introducing themself? Introduction makes it easier to identify an account as a human being taking responsibility of its contribution. Please help me on that point. This might prevent situations like this in the future.

[tsenk]

I get your issue with AI spam but there's many ways to figure out whether something is ai which don't take much effort. In most cases it should be obvious just from the PR description. I specifically highlighted how i used both f_bavail and f_bfree. That should be a clear sign it's human by itself. You can even have a glance at people's profiles.

I actually read the contributor guide. I didn't respond to your comment with faq because it really put me under the impression you will be difficult to work with, when I get treated as spam off rip. AIs don't stop responding suddenly, if I was one I'd reply in 30 seconds. I value efficiency most, I don't really see a need for a big formal introduction, especially when I'm only contributing a 40 line fix to a 5 year old issue. I looked at other PRs that were merged and most of them don't include one. If you want to motivate contributors, treat all PRs with the same respect at the start.

I'm fine with finishing this. I ran it on Debian 13 wsl, the label should show up, and all tests ran successfully locally. I'd appreciate if it could be tested on a real linux machine, even though wsl has the same posix filesystem. I can't give you a screenshot right now, I'm replying on mobile.

[buhtz]

Hello tsenk,
thank you for the reply and information. I understand your feelings about this situation.

Introduction don't need to be "long". One or two simple sentences making it easy identifing you has a human being and get an idea if it is a students low-effort home work or not.

Let's put this aside as a misunderstanding.

I gave your code a quick review on the day you opened the PR. The widget might be there. But it seems not to be functional because set_disk_space_info() is never called.

But from what I do see from you right know, I am assuming this is on purpose. You try to keep the PR as simple as possible, am I right? You add the widget, but without logic behind it?

• What are your next steps? Adding functionality in this or another PR?
• Could you please have look at the linter output at the CI? The test suite runs several linters, but only if they are available on the system. That might be the reason that you couldn't see the linter warnings on your local machine. Ruff, Flake8 and PyLint are not satisfied.

Regards,
Christian