Skip to content

Conversation

@bittoshimoto
Copy link

Please check out does all is ok if there are any errors let me know

@ltardivo
Copy link
Collaborator

Thanks for this PR. I left a few comments. The code is evolving and probably you started from an old branch. Take a look to my comments, some files were removed since version 0.24.
The other important change you have to do is to modify NakamotoJs library. Here is this PR from the Pepecoin community and this other PR that you can follow as inspiration.

"name": "@bitcoin-computer/node",
"version": "0.26.0-beta.0",
"private": false,
"version": "0.20.0-beta.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not recommend to modify the node package.json file appart from setting the name of the blockchain in the keywords.

@@ -0,0 +1,69 @@
#!/usr/bin/env node
// Copyright (c) 2021-2023 Bitcoin Computer developers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have removed this file. I recommend you to take a pull from staging and start from there.

@@ -0,0 +1,37 @@
#!/usr/bin/env python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have remove this script, now the services are stopped in a more simple way from the package.json. It is probably better to check the differences with the last version of the staging branch

@@ -0,0 +1,73 @@
#!/usr/bin/env node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before, we have removed this script

@@ -0,0 +1,49 @@
#!/usr/bin/env python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before, we have removed this script

@@ -0,0 +1,11 @@
MNEMONIC=capital hurdle actual tunnel stool pause measure fresh deer mass thrive route fame initial bind
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Wallet app is now a Vite one. This may be old. Please, check against staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants