Jade native psbt

[JamieDriver]

1. latest jade api to recognise more recently added hw (now available as its own PR, jade: update Jade api to 1.0.33 #768)
2. remove code which walked psbt and mapped it into Jade's legacy 'sign_tx' json format - instead pass PSBT directly to Jade for signing, since this has been supported in fw now for well over a year and seems to be working well.

[brunoerg]

Concept ACK

[JamieDriver]

Thanks - any idea what's up with the CI ? Always feel more confident when CI looks good ...

[achow101]

Thanks - any idea what's up with the CI ? Always feel more confident when CI looks good ...

You need to rebase.

[JamieDriver]

Probably best superseded by #763

[achow101]

We prefer to support as old firmware as possible. This bumps the minimum supported firmware version, but it looks like it would be trivial to keep all of the old code while still using native PSBTs for newer firmware versions.

[JamieDriver]

Fair enough - I think I bumped the min version to 0.1.47, which was released in March 2023, so nearly 2 years old.
But ok, as you say supporting both is perfectly doable if we don't mind the ongoing maintenance overhead of legacy code.

I'll split the 'upgrade Jade api' off into it's own PR as that is more straightforward (and should be uncontentious now that #763 has been 'concept-nack'-ed) and is needed if HWI is to support the latest generation of Jade hardware.

Opened PR: #768

[JamieDriver]

Rebased onto #768 (so this PR implicitly includes that PR), and retained support for legacy signing for old firmwares.
Thanks.

[achow101]

Rebase for #768 and also there's an actual CI failure.

hwilib/devices/jade.py:380: error: Returning Any from function declared to return "PSBT"  [no-any-return]

[JamieDriver]

Addressed, many thanks.

[achow101]

ACK c66dd1a