Open
Conversation
Member
|
Looks like it's still failing https://github.com/bitcoin-core/HWI/actions/runs/10774640633/job/29879492171?pr=756#logs |
1eec64d to
7e8bdea
Compare
Contributor
Author
|
Moved to draft to investigate it better. It will need more changes. |
Member
|
I incorporated the Unfortunately the logs are gone, so not sure what the other failures were. |
Contributor
Author
Cool, I will take a look at that. |
Member
|
Please rebase, now that #795 landed. |
7e8bdea to
ed007bc
Compare
ed007bc to
cfb5302
Compare
Contributor
Author
|
Done. |
Member
|
There's been a ton of CI changes, is this still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coldcard job (for different python versions) is failling due to the following error:
From CI (e.g https://github.com/bitcoin-core/HWI/actions/runs/10762544360/job/29843131139):
According to the coldcard documentation (https://github.com/Coldcard/firmware?tab=readme-ov-file#linux), besides running
pip install -r requirements.txt, it's required to installpysdl2-dll.