Introduce Send pages for singlesig, single input/output send #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current: Screencast.from.2025-02-20.10-18-37.mp4Goal: basic_send_flow_prototype.mp4There are a few immediate things I will be working on adjusting within the context of this PR to match the proposed designs. Primarily I will focus on the layout of the pages to match as well as the transition animations. |
johnny9
changed the title
MarnixCroes
reviewed
Feb 21, 2025
There was a problem hiding this comment.
- It happens many times that clicking the
Reviewbutton doesn't work.
Nothing happens, it doesn't go to SendReview page.
And then after adding or removing a zero it works. (always below balance)
- The address is cleared after send is confirmed and navigated back to Send page, the
AmountandNoteshould be cleared too?
| } | ||
| } | ||
|
|
||
| ContinueButton { |
There was a problem hiding this comment.
maybe
make the button only click-able / highlighted on hover when there is a valid input?
hebasto
reviewed
Feb 27, 2025
There was a problem hiding this comment.
To fix the build error:
RCC: Error in 'qml/bitcoin_qml.qrc': Cannot find file 'controls/LabeledTextInput.qml'
I suggest (UPDATED):
--- a/src/Makefile.qt.include
+++ b/src/Makefile.qt.include
@@ -353,6 +353,7 @@ QML_RES_ICONS = \
qml/res/icons/cross.png \
qml/res/icons/error.png \
qml/res/icons/export.png \
+ qml/res/icons/flip-vertical.png \
qml/res/icons/gear.png \
qml/res/icons/gear-outline.png \
qml/res/icons/hidden.png \
@@ -396,6 +397,7 @@ QML_RES_QML = \
qml/controls/ContinueButton.qml \
qml/controls/CoreText.qml \
qml/controls/CoreTextField.qml \
+ qml/controls/LabeledTextInput.qml \
qml/controls/ExternalLink.qml \
qml/controls/FocusBorder.qml \
qml/controls/Header.qml \Why not keep files in buildsystem scripts sorted?
|
Want to update the PR and fix the CI? |
johnny9
force-pushed
the
send-pr
branch
3 times, most recently
from
0490d58 to
9a863b0
Compare
|
Update:
|
|
Needs rebase. |
johnny9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement the first iteration of the Send coins flow for our Desktop Wallet. A QML model, SendRecipient, is defined to hold the values entered into the Send form which will then be used to construct the actual transaction. The resulting transaction will be held in another new QML model, WalletQmlModelTransaction, and that will be held by the WalletModel and used to render the confirmation page, SendReview.qml. This is designed to closely mirror the objects used in the current Qt SendCoinsDialog modules.