Add Skeleton loading to Activity #460
Conversation
|
ACK. Looks great. I can't quite test it since I don't have a wallet that takes a long time to load, so I am just looking the video. There are some minor visual tweaks to do, but those can be done in a separate PR. How can I test this properly? Do I need to create a wallet with 1K fake transactions? Or is there a fake delay I could insert in the code somewhere? |
testnet and regtest wallets seem to work for me. With regtest, you can create a new wallet and use the generatetoaddress 101 myaddress to create a bunch of coinbase coins to yourself. For testnet, if you send me an address I try to send some utxos to you |
johnny9
force-pushed
the
activity-skeleton
branch
from
fa22e43 to
b987ae5
Compare
|
ACK. I just changed As I mentioned in my previous comment, I think we can merge this and do some minor visual polish later. |
508859c qml: Add Skeleton loading to Activity (johnny9) Pull request description: https://github.com/user-attachments/assets/0b934c17-e1e3-4d60-b846-8b86949f8765 Top commit has no ACKs. Tree-SHA512: 0b3033a0285fb8df3ced6672d9285e88140599791bad77e5247f99931e11b8d8462ca3a620452e086c0e35a8f627e2e0e79f9cb89d8e2c86954d3a6e1b682f2f
508859c2cdcd9018868d448c5eef4ca0c30ef4cb qml: Add Skeleton loading to Activity (johnny9) Pull request description: https://github.com/user-attachments/assets/0b934c17-e1e3-4d60-b846-8b86949f8765 Top commit has no ACKs. Tree-SHA512: 0b3033a0285fb8df3ced6672d9285e88140599791bad77e5247f99931e11b8d8462ca3a620452e086c0e35a8f627e2e0e79f9cb89d8e2c86954d3a6e1b682f2f
4 participants
activity-skeleton.mp4