Merged
Conversation
johnny9
reviewed
Jun 2, 2025
| initialItem: Page { | ||
| id: root | ||
| background: null | ||
| initialItem: RowLayout { |
Collaborator
There was a problem hiding this comment.
shouldn't Page be the initial item? What is RowLayout doing with only one child?
Contributor
Author
There was a problem hiding this comment.
to set these layout properties in the page child
Layout.alignment: Qt.AlignCenter
Layout.fillHeight: true
Layout.fillWidth: true
Layout.maximumWidth: 600
Layout.margins: 20
johnny9
approved these changes
Jun 3, 2025
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
30ea70e qml: Remove inner stack view from about settings (goqusan) 91dc9d9 qml: Remove anchors from node settings (goqusan) 98338ef qml: Fix layout in activity view (goqusan) aca5df9 qml: Use content item on desktop wallets (goqusan) Pull request description: - avoid anchors, use layouts - override contentItem - avoid nested stack view ACKs for top commit: johnny9: ACK 30ea70e Tree-SHA512: 0093bad621dc989fe1825907e20b7e3c45c265cac9245827153e3ab4f4593c6c4dc50993f5c5cf15f7b3a78e0798b4529e0500b9cd881a5bf0fa222ab855d237
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
30ea70e718e7c153d31b31346aa084e9cfd1ec40 qml: Remove inner stack view from about settings (goqusan)
91dc9d988fc0fca3bbb8cb8521081bc1cdc99dd1 qml: Remove anchors from node settings (goqusan)
98338efef61ac40c8713ce792b16ea31ae4fb0a9 qml: Fix layout in activity view (goqusan)
aca5df9fc888e3ef71e452f3473f770c3359f386 qml: Use content item on desktop wallets (goqusan)
Pull request description:
- avoid anchors, use layouts
- override contentItem
- avoid nested stack view
ACKs for top commit:
johnny9:
ACK 30ea70e718e7c153d31b31346aa084e9cfd1ec40
Tree-SHA512: 0093bad621dc989fe1825907e20b7e3c45c265cac9245827153e3ab4f4593c6c4dc50993f5c5cf15f7b3a78e0798b4529e0500b9cd881a5bf0fa222ab855d237
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.