Fix layout issues in ExternalPopup.qml #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
8c7f2cbf399c42241af4cb00c2807bca9ff232c2 Fix layout issues in ExternalPopup.qml (johnny9)
Pull request description:
Simplifies the layout in ExternalPopup by using CoreText instead of Navigation bar for the title, removing an extra ColumnLayout, and using GridLayout to handle the difference between mobile and desktop.
This resolves the "Qt Quick Layouts: Polish loop detected" warning.
Fixes #483
ACKs for top commit:
hebasto:
ACK 8c7f2cbf399c42241af4cb00c2807bca9ff232c2, tested on Ubuntu 24.04.
Tree-SHA512: 556b3c334b330a5db10f44e34e857a1d2a07784ca1eaae6af6e6b456b752bf7a9f40f8b5d34a2ef8d6aae69c1e67ca94f9b588e68fcfb04ceae39e34f43d4306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the layout in ExternalPopup by using CoreText instead of Navigation bar for the title, removing an extra ColumnLayout, and using GridLayout to handle the difference between mobile and desktop.
This resolves the "Qt Quick Layouts: Polish loop detected" warning.
Fixes #483