Skip to content

musig: add input JSON files for generating test vectors #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
theStack wants to merge 1 commit into
base: master
Choose a base branch
from
Open

musig: add input JSON files for generating test vectors #1786

theStack wants to merge 1 commit into from

Conversation

@theStack
Copy link
Contributor

@theStack theStack commented Dec 12, 2025

While looking up past review history of the previous silentpayments PR (take 3), I've found that adding the input JSON files for generating the musig test vectors was suggested once there: #1698 (comment)

Can be tested by first comparing that the .json files match the ones from the bips repository's bip-0327/vectors folder and then running e.g.

$ rm src/modules/musig/vectors.h
$ make src/modules/musig/vectors.h
$ git diff
<should not show any diff>

real-or-random
real-or-random reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

@kevkevinpal
Copy link
Contributor

kevkevinpal commented Dec 13, 2025

Concept ACK

I was also able to run these commands and get the same results

$ rm src/modules/musig/vectors.h
$ make src/modules/musig/vectors.h
$ git diff
<should not show any diff>

real-or-random
real-or-random approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 12bba63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@real-or-random real-or-random real-or-random approved these changes

Assignees

No one assigned

Labels

assurance tweak/refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theStack @kevkevinpal @real-or-random