BIP380: make specs consistent about hardened indicators #1803
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me and my students noticed a discrepancy in the test vectors and specification regarding the allowed characters denoting hardened nodes. The BIP380 specs allows all three
h
,'
andH
, in particular the specs read:However, the following is then an invalid test vectors:
Thus, I've added new test vectors allowing
H
and removed the inconsistent one.However, I am far from claiming that this is the correct way how to handle this. I've checked that people are using the
H
, but I got no (meaningful or relevant) hits when searching for the exact test vector. I didn't see the option to create issues, thus I've continued by proposing the, what seems to be, reasonable changes.