Skip to content

BIP380: make specs consistent about hardened indicators #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quapka
Copy link
Contributor

@quapka quapka commented Mar 27, 2025

Me and my students noticed a discrepancy in the test vectors and specification regarding the allowed characters denoting hardened nodes. The BIP380 specs allows all three h, ' and H, in particular the specs read:

In the above specification, the hardened indicator h may be replaced with alternative
hardened indicators of H or '.

However, the following is then an invalid test vectors:

[deadbeef/0H/0H/0H]0260b2003c386519fc9eadf2b5cf124dd8eea4c4e68d5e154050a9346ea98ce600

Thus, I've added new test vectors allowing H and removed the inconsistent one.

However, I am far from claiming that this is the correct way how to handle this. I've checked that people are using the H, but I got no (meaningful or relevant) hits when searching for the exact test vector. I didn't see the option to create issues, thus I've continued by proposing the, what seems to be, reasonable changes.

@jonatack jonatack added Proposed BIP modification Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified labels Mar 28, 2025
@jonatack jonatack changed the title Make specs consistent about hardened indicators BIP380: make specs consistent about hardened indicators Mar 28, 2025
@murchandamus
Copy link
Contributor

cc: @achow101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified Proposed BIP modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants