Skip to content

BIP-99: fix footnotes and drop missing reference #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

torrpriius
Copy link
Contributor

@torrpriius torrpriius commented Apr 30, 2025

No description provided.

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about the proposed link. It might be more useful to either fix the footnotes formatting so that they work, or remove them.

@torrpriius
Copy link
Contributor Author

@jonatack
I've updated the footnote formatting to match the rest of the document. The placeholder [non_proportional_inflatacoin_fork] has been replaced with a numbered reference [3], and all in-text mentions have been aligned accordingly. The link now points to a relevant Bitcointalk discussion that illustrates the concept of a "schism hardfork" described in that section.

@jonatack
Copy link
Member

Hi @torrpriius, the footnote formatting looks like a good improvement. I am unconvinced by the proposed new link.

@torrpriius
Copy link
Contributor Author

Hi @jonatack, i kept the [3] reference to stay consistent with the other footnotes and added a clear TODO in the footnote asking for a reliable source.
This keeps the structure clean, and others can easily add the right link later when it's found.

Copy link
Contributor

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look at how to improve the formatting of this document.

"spinoffs"[spinoffs] that distribute all or part of its initial seigniorage to
"spinoffs"[3] that distribute all or part of its initial seigniorage to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reuses the [3] for a second reference.


[spinoffs] https://bitcointalk.org/index.php?topic=563972.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally dropped this reference.

@murchandamus
Copy link
Contributor

I dropped the missing reference instead of guessing at the open todo, and fixed the formatting of the footnotes by using the reference syntax.

@murchandamus
Copy link
Contributor

@jonatack: Unless you think we should keep the prior open todo, this may be RFM.

@jonatack jonatack changed the title BIP-99: Replace placeholder with relevant link for Inflatacoin fork BIP-99: fix footnotes and drop missing reference May 21, 2025
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7ab94f8

Thanks @torrpriius for updating and @murchandamus for the fixups.

@jonatack
Copy link
Member

Updated the PR title/description.

@jonatack jonatack merged commit fd413c1 into bitcoin:master May 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants