-
Notifications
You must be signed in to change notification settings - Fork 5.7k
BIP-99: fix footnotes and drop missing reference #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about the proposed link. It might be more useful to either fix the footnotes formatting so that they work, or remove them.
@jonatack |
Hi @torrpriius, the footnote formatting looks like a good improvement. I am unconvinced by the proposed new link. |
Hi @jonatack, i kept the [3] reference to stay consistent with the other footnotes and added a clear TODO in the footnote asking for a reliable source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking a look at how to improve the formatting of this document.
bip-0099.mediawiki
Outdated
"spinoffs"[spinoffs] that distribute all or part of its initial seigniorage to | ||
"spinoffs"[3] that distribute all or part of its initial seigniorage to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this reuses the [3] for a second reference.
|
||
[spinoffs] https://bitcointalk.org/index.php?topic=563972.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You accidentally dropped this reference.
Co-authored-by: Murch <[email protected]>
I dropped the missing reference instead of guessing at the open todo, and fixed the formatting of the footnotes by using the reference syntax. |
@jonatack: Unless you think we should keep the prior open todo, this may be RFM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7ab94f8
Thanks @torrpriius for updating and @murchandamus for the fixups.
Updated the PR title/description. |
No description provided.