BIP-345: withdraw #1848
BIP-345: withdraw #1848
Conversation
| Greg Sanders <[email protected]> | ||
| Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0345 | ||
| Status: Draft | ||
| Status: Withdrawn |
There was a problem hiding this comment.
The README would need updating as well.
There was a problem hiding this comment.
Probably a diff like this
diff --git a/README.mediawiki b/README.mediawiki
index fe3be265..2ea96ed3 100644
--- a/README.mediawiki
+++ b/README.mediawiki
@@ -1127,13 +1127,13 @@ Standard
| Final
-|-
+|- style="background-color: #ffcfcf"
| [[bip-0345.mediawiki|345]]
| Consensus (soft fork)
| OP_VAULT
| James O'Beirne, Greg Sanders
| Standard
-| Draft
+| Withdrawn
|-
| [[bip-0347.mediawiki|347]]
| Consensus (soft fork)
There was a problem hiding this comment.
Based on your comment, you may also want to add Superseded-By: [bip-number-of-OP_CCV-coming-soon™] below the Post-History header.
There was a problem hiding this comment.
I.e., Superseded-By: 443.
jamesob
force-pushed
the
jamesob-25-05-withdraw-vault
branch
from
c09fcd6 to
65c0f7b
Compare
| | James O'Beirne, Greg Sanders | ||
| | Standard | ||
| | Draft | ||
| | Withdrawn |
There was a problem hiding this comment.
Line 1130 should be
|- style="background-color: #ffcfcf"
to match the status change.
bip-0345.mediawiki
Outdated
| Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0345 | ||
| Status: Draft | ||
| Status: Withdrawn | ||
| Superseded-By: 443 |
There was a problem hiding this comment.
Please move the Superseded-By header below the Post-History header. The headers are required to be in a specific order.
|
The CI is failing because of the color of the table row in the README.mediawiki |
murchandamus
force-pushed
the
jamesob-25-05-withdraw-vault
branch
from
65c0f7b to
b771054
Compare
|
Edited with permission of @jamesob to fix CI issue. Checked with @instagibbs out-of-band who supports the change. |
3 participants
This proposal has basically been replaced by #1793. See https://delvingbitcoin.org/t/withdrawing-op-vault-bip-345/1670 for rationale.