BIP32: Use plural “bytes” #1899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvention Aligns the first field in the serialization table with the rest, which use plural “bytes” (e.g., “4 bytes: child number”) for consistency.
jonatack
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jonatack
reviewed
Jul 23, 2025
|
|
||
| Extended public and private keys are serialized as follows: | ||
| * 4 byte: version bytes (mainnet: 0x0488B21E public, 0x0488ADE4 private; testnet: 0x043587CF public, 0x04358394 private) | ||
| * 4 bytes: version bytes (mainnet: 0x0488B21E public, 0x0488ADE4 private; testnet: 0x043587CF public, 0x04358394 private) |
Member
There was a problem hiding this comment.
Generally, we collect all the typos at the end of the month into one pull request. At the moment, the only other typo fix this month is #1892 (comment).
Contributor
|
I decided to merge this, since it seemed like less work after having looked at this PR a few times already. |
Member
|
#1905 was just opened 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo fixup: Align the first field in the serialization table with the rest, which use plural “bytes” (e.g., “4 bytes: child number”) for consistency.