BIP 434: Peer Feature Negotiation#2076
Conversation
murchandamus
changed the title
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Thanks for your submission. This proposal appears already complete from an editorial perspective, and I have hardly any other comments. It would be great to see some P2P experts weigh in, but otherwise, this seems fairly mature.
| Nodes implementing this BIP MAY disconnect peers that send `feature` | ||
| messages where the `feature` message's payload cannot be correctly | ||
| parsed (including having missing or additional data), even if they do | ||
| not recognise the `featureid`. |
There was a problem hiding this comment.
It may be clearer to place this paragraph after the next one, as the "even if" phrase is confusing before reading the next paragraph.
There was a problem hiding this comment.
I think it should be phrased more positively to disambiguate:
Nodes implementing this BIP MAY disconnect peers that send `feature`
messages where the `feature` message's payload cannot be correctly
parsed (including having missing or additional data). In the special case where a node is able to partially parse the message to read the `featureid`, but they do not recognise the `featureid`, they SHOULD NOT disconnect (to preserve upgradability of feature messages).
This is a valid reinterpretation of the earlier bit because the "MAY" disconnect is truly optional, so the addition of a SHOULD NOT doesn't modify the semantic, but makes it more clear what should be implemented, while still retaining valid behavior if a node disconnects because of upgraded feature types.
| but no experience with doing so via `verack` payload. | ||
|
|
||
| A mild disadvantage compared to using a `verack` payload is that this | ||
| approach allows the possibility of interactive feature negotiation prior |
There was a problem hiding this comment.
I may be confused.
| approach allows the possibility of interactive feature negotiation prior | |
| approach does not allow the possibility of interactive feature negotiation prior |
There was a problem hiding this comment.
The idea is that interactive feature negotiation is a "bad" thing, as it makes negotiation more complex and potentially slower, so allowing it is a disadvantage.
|
Let’s call this BIP 434. |
murchandamus
changed the title
bip-peer-feature-negotiation.md
Outdated
| parsed (including having missing or additional data), even if they do | ||
| not recognise the `featureid`. | ||
|
|
||
| Nodes implementing this BIP MUST ignore `feature` messages specifying a |
There was a problem hiding this comment.
this is not a MUST, it's a SHOULD
There was a problem hiding this comment.
No, it is a MUST; implementations that do not comply with that requirement do not correctly implement this specification.
The reason it's a requirement is that not ignoring such messages means your implementation is not forwards compatible with new features.
ajtowns
force-pushed
the
202512-p2p-feature
branch
from
9697b2b to
9630c4c
Compare
|
|
||
| Nodes implementing both this BIP and [BIP 324 (v2 P2P encrypted | ||
| transport)][BIP324] MUST treat a message with a 1-byte `message_type` | ||
| equal to `XXX` that is received prior to `verack` as the `feature` message. |
There was a problem hiding this comment.
Should synchronise specifying a real number here with updating BIP 324 to claim that number.
There was a problem hiding this comment.
It seems reasonable to add the change of BIP 324 to this PR in the same commit. Or alternatively, that could be another separate PR after this document is published before it’s progressed to Complete.
|
Updated for number assignment, BIP3 headers, and @jonatack's phrasing suggestions |
4 participants
Abstract:
This BIP defines a peer-to-peer message that can be used for announcements and negotiation related to support of new peer-to-peer features.
Mailing list post: https://gnusha.org/pi/bitcoindev/aUUXLgEUCgGb122o@erisian.com.au/T/#u
Mailing list discussion: https://groups.google.com/g/bitcoindev/c/DFXtbUdCNZE