feat: support taproot for signAllInputsHD#2137
feat: support taproot for signAllInputsHD#2137jasonandjay wants to merge 6 commits intobitcoinjs:masterfrom
Conversation
jasonandjay
commented
Jul 24, 2024
- issue discussion: Feature Request: Taproot support for signAllInputsHD #2132
- feat
- affected Signature Methods
- signAllInputsHD
- signAllInputsAsyncHD
- signInputHD
- signInputAsyncHD
- remove conflict default sighashTypes of signInputHD
- Transaction.SIGHASH_DEFAULT for _signTaprootInput
- Transaction.SIGHASH_ALL for _signInput
- so we should remove the outermost default signType
- add integration test for HDWallet with tapBip32Derivation
- we will need more integration tests later.
- affected Signature Methods
This comment was marked as resolved.
This comment was marked as resolved.
|
How about code review progress? |
|
@junderw Could you check this PR? |
|
I have an observation regarding the asymmetry in I'm not saying this is incorrect, but this PR allows On the other hand, in As a result, it's not possible to use Again, I'm not saying this is necessarily wrong. Perhaps this is the only viable approach, but I wanted to highlight this to see if there’s anything further we can do, or at least reflect this behavior more clearly in the comments at the top of |