Staging: update for maxmind URL changes and 302 redirects#24
Merged
prdn merged 2 commits intobitfinexcom:masterfrom May 1, 2024
Merged
Staging: update for maxmind URL changes and 302 redirects#24prdn merged 2 commits intobitfinexcom:masterfrom
prdn merged 2 commits intobitfinexcom:masterfrom
Conversation
vigan-abd
requested changes
Apr 30, 2024
vigan-abd
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maxmind updates are currently broken due to the download URLs being deprecated: https://dev.maxmind.com/geoip/release-notes/2024#presigned-urls-for-database-downloads
This is basically an upstream merge of https://github.com/geoip-lite/node-geoip/blob/main/scripts/updatedb.js to fix
Additionally, here is an upstream feature so we can delete this script from our repository: geoip-lite/node-geoip#265