Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch Davi0kProgramsThings:fix/refactoring into branch bitfinexcom:master. #235

Merged
merged 14 commits into from
Mar 5, 2024
Merged

Merge branch Davi0kProgramsThings:fix/refactoring into branch bitfinexcom:master. #235

merged 14 commits into from
Mar 5, 2024

Commits on Feb 26, 2024

  1. Add isort, black and flake8 to dev-requirements.txt (+ remove support… 

    … to pylint).
    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d3f402f View commit details
    Browse the repository at this point in the history

  2. Apply isort to all python files (bfxapi/**/*.py).

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2b7dfc5 View commit details
    Browse the repository at this point in the history

  3. Apply black to all python files (bfxapi/**/*.py).

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    38dbff1 View commit details
    Browse the repository at this point in the history

  4. Configure flake8 tool with some custom options.

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6a70069 View commit details
    Browse the repository at this point in the history

  5. Remove all old '# pylint:' comments from all python files.

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2344d44 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Fix all flake8 errors in all python files (+ edit configuration files).

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5543b0b View commit details
    Browse the repository at this point in the history

  2. Split isort, black and flake8 configuration in .isort.cfg, .flake8 an… 

    …d pyproject.toml.
    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e225756 View commit details
    Browse the repository at this point in the history

  3. Fix flake8 configuration to respect Black's 10% rule.

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1a6f4ea View commit details
    Browse the repository at this point in the history

  4. Install and configure pre-commit (to work with isort, black and flake8).

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e4c7acd View commit details
    Browse the repository at this point in the history

  5. Edit .github/workflows/bitfinex-api-py-ci.yml to run pre-commit hooks.

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9803798 View commit details
    Browse the repository at this point in the history

  6. Downgrade pre-commit version to 3.5.0 (dev-requirements.txt).

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    48df3fa View commit details
    Browse the repository at this point in the history

  7. Edit .gitignore to exclude more files/folders.

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ababa73 View commit details
    Browse the repository at this point in the history

  8. Add new tasks to .github/PULL_REQUEST_TEMPLATE.md.

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4f0f5ef View commit details
    Browse the repository at this point in the history

  9. Edit README.md documentation to add chapter on pre-commit.

    @Davi0kProgramsThings
    Davi0kProgramsThings committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f94096b View commit details
    Browse the repository at this point in the history