Support UnifiedPush Connector 3.x #1325
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
1 task
|
This PR/issue depends on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
Cannot properly test because we still do not support encryption with our current implementation of DAVPush.
Depends on bitfireAT/dav4jvm#64
Purpose
Upgrade the UnifiedPush connector version to the latest one (3.0.4). This one includes built-in support for message encryption.
Also gives support to DAVPush encryption with VAPID and message encryption.
Right now we do not have any working server and/or implemented with support for push with encryption, so I'm not sure how to test it.
Short description
Upgrade UnifiedPush Connector.
Note that there seems to be a bug in a dependency they use, so they import it locally:
https://github.com/UnifiedPush/android-connector/blob/28cb0d622ed0a972996041ab9cc85b701abc48c6/connector/build.gradle#L56-L59
It breaks the build because of duplicated libraries, so I've had to exclude it from UnifiedPush. I guess that when Fix spec compliant record size verification tink-crypto/tink-java-apps#5 is merged they will release a new version.
For some reason push is broken right now, I don't know if it's our fault, UnifiedPush's fault, or the Nextcloud server's fault.
Checklist