Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move InvalidAccountException to account package #1342

Open
wants to merge 1 commit into
base: main-ose
Choose a base branch
from
Open

Move InvalidAccountException to account package #1342

wants to merge 1 commit into from

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Mar 11, 2025

Away from root package

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Mar 11, 2025
@rfc2822 rfc2822 requested a review from sunkup March 11, 2025 23:05
@rfc2822 rfc2822 self-assigned this Mar 11, 2025
sunkup
sunkup approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright 👍

How come AccountRepository.rename will throw InvalidAccountException when the account does not exist? I can't see the method or the service repository throwing InvalidAccountException.

https://github.com/bitfireAT/davx5-ose/pull/1342/files#diff-954ef783acf4b5c0bcb7be1f0c0babf0ba0d09bc851350134153a16b0e3e00f3R174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@rfc2822 rfc2822

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfc2822 @sunkup