-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerelease v-9.3.0-pre-01 (#9653) #9656
Prerelease v-9.3.0-pre-01 (#9653) #9656
Conversation
WalkthroughThis pull request involves a comprehensive version update across multiple projects and components from version Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)
177-178
: Consider adding a pre-release warning noteSince this is a user-facing documentation page and we're referencing a pre-release version (9.3.0-pre-01), consider adding a note warning users about potential instability in pre-release versions.
<div style="margin-bottom:8px">Install <a href="https://www.nuget.org/packages/Bit.Boilerplate/9.3.0-pre-01" target="_blank">Bit Boilerplate</a> project template</div> +<div class="warning-note">Note: This is a pre-release version and may contain breaking changes or instability.</div> <CodeBox>dotnet new install Bit.Boilerplate::9.3.0-pre-01</CodeBox>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (43)
src/Besql/Bit.Besql/wwwroot/bit-besql.js
(1 hunks)src/Bit.Build.props
(1 hunks)src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj
(1 hunks)src/BlazorUI/Demo/Directory.Build.props
(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.js
(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.ts
(1 hunks)src/Butil/Bit.Butil/Scripts/butil.ts
(1 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
(2 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props
(2 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj
(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj
(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
(1 hunks)src/Websites/Careers/src/Directory.Build.props
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
(1 hunks)src/Websites/Platform/src/Directory.Build.props
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
(1 hunks)src/Websites/Sales/src/Directory.Build.props
(1 hunks)
✅ Files skipped from review due to trivial changes (26)
- src/Websites/Platform/src/Directory.Build.props
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
- src/Websites/Sales/src/Directory.Build.props
- src/Bswup/FullDemo/Client/wwwroot/service-worker.js
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
- src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
- src/Websites/Careers/src/Directory.Build.props
- src/BlazorUI/Demo/Directory.Build.props
- src/Butil/Bit.Butil/Scripts/butil.ts
- src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
- src/Bup/Bit.Bup/Scripts/bit-bup.ts
- src/Besql/Bit.Besql/wwwroot/bit-besql.js
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
- src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
- src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
- src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
- src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
- src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build and test for release
🔇 Additional comments (18)
src/Bit.Build.props (1)
Line range hint
30-34
: LGTM! Version update follows semantic versioning.The version update to
9.3.0-pre-01
is properly formatted and consistently applied across the version properties. TheVersion
property correctly handles the pre-release tag conversion.src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1)
41-41
: Verify the impact of using pre-release version in template installation.The template installation command now uses the pre-release version
9.3.0-pre-01
. Ensure that users are aware they're installing a pre-release version.Consider:
- Adding a warning or notice about the pre-release status
- Documenting any potential instabilities or breaking changes
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (1)
4-11
: LGTM! Package versions are consistently updated.All Bit.* packages have been updated to version
9.3.0-pre-01
, maintaining version consistency across the package ecosystem.Run this script to verify version consistency across all Bit.* packages:
Also applies to: 49-49
✅ Verification successful
Package versions are consistently set to 9.3.0-pre-01
All Bit.* package versions in the codebase are consistently managed through central package version management and set to version 9.3.0-pre-01. No inconsistencies were found.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any inconsistent versions of Bit.* packages rg -A 1 'Include="Bit\.' | rg -v '9\.3\.0-pre-01'Length of output: 18969
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (1)
4-11
: Verify compatibility with .NET 9.0.0.The Bit.* packages have been updated to pre-release version
9.3.0-pre-01
while using .NET 9.0.0 dependencies.Please verify:
- Compatibility between pre-release Bit.* packages and .NET 9.0.0
- Any required changes in the packages to support .NET 9.0.0
Run this script to check for potential compatibility issues:
Also applies to: 52-52
✅ Verification successful
Compatibility between Bit. packages and .NET 9.0.0 is verified*
The codebase shows proper integration between Bit.* packages version 9.3.0-pre-01 and .NET 9.0.0 dependencies, with consistent versioning and appropriate framework targeting across multiple projects.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for .NET version requirements in Bit.* packages rg -A 5 'TargetFramework|<PackageReference' | rg 'net9\.0|Bit\.'Length of output: 73346
src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj (1)
9-16
: Verify compatibility with .NET 9.0The project is targeting .NET 9.0 while using pre-release versions of Bit.CodeAnalyzers and Bit.SourceGenerators. Please ensure these pre-release versions are compatible with .NET 9.0.
✅ Verification successful
Pre-release analyzers are compatible with .NET 9.0
The pre-release versions of Bit.CodeAnalyzers and Bit.SourceGenerators (9.3.0-pre-01) are actively used in the codebase targeting .NET 9.0 without any compatibility issues. The version numbers align with .NET 9.0, and the analyzers are successfully integrated with modern .NET features.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if there are any reported issues or incompatibilities between the analyzers and .NET 9.0 # Search for any error or warning comments related to analyzer compatibility rg -i "compatibility|error|warning|issue" --type cs -g "*.cs" -C 2Length of output: 66424
src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj (1)
8-15
: LGTM! Version updates are consistentThe version updates for Bit.CodeAnalyzers and Bit.SourceGenerators are consistent with the overall pre-release version update.
src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1)
13-20
: Verify version consistency across project referencesThe project references Bit.Websites.Sales.Client and Bit.Websites.Sales.Shared. Please ensure that all Bit.* package versions are consistent across these projects.
✅ Verification successful
All Bit. package versions are consistent*
All Bit.* packages across the Sales website projects (Server, Client, and Shared) consistently use version 9.3.0-pre-01.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check version consistency of Bit.* packages across referenced projects # Search for Bit.* package references in all .csproj files rg -A 1 '<PackageReference Include="Bit.' --type xml -g "*.csproj" | grep -E 'Include=|Version='Length of output: 9643
src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1)
13-20
: LGTM! Version updates are consistent.The package version updates for
Bit.CodeAnalyzers
andBit.SourceGenerators
to9.3.0-pre-01
align with the prerelease version update objective.src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1)
13-20
: LGTM! Version updates are consistent.The package version updates align with the prerelease version update objective.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1)
27-36
: LGTM! Comprehensive version updates.All Bit.* package references have been consistently updated to version
9.3.0-pre-01
, including:
- Bit.Bswup
- Bit.CodeAnalyzers
- Bit.SourceGenerators
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)
32-39
: LGTM! Version updates are consistent.Package version updates align with the prerelease version update objective.
src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (1)
25-36
: LGTM! Verify UI components compatibility.All Bit.* package versions have been consistently updated to
9.3.0-pre-01
. Since this includes UI components (BlazorUI, Icons, Assets), it would be good to verify that there are no breaking changes in the UI.Run the following script to check for any breaking changes in the UI components:
src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (2)
25-28
: LGTM! Package versions are consistent.The version updates for Bit.BlazorUI packages are consistent with the pre-release version v-9.3.0-pre-01.
29-36
: LGTM! Analyzer package versions are consistent.The version updates for Bit.CodeAnalyzers and Bit.SourceGenerators are aligned with other package updates.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1)
19-25
: LGTM! Analyzer package versions are consistent.The version updates for Bit.CodeAnalyzers and Bit.SourceGenerators align with the pre-release version.
src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (2)
25-29
: LGTM! Package versions are consistent.The version updates for Bit.Butil, Bit.BlazorUI, and related packages align with the pre-release version.
30-36
: LGTM! Analyzer package versions are consistent.The version updates for Bit.CodeAnalyzers and Bit.SourceGenerators match other package updates.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1)
88-91
: LGTM! Analyzer package versions are consistent.The version updates for Bit.CodeAnalyzers and Bit.SourceGenerators align with the pre-release version.
Also applies to: 93-96
closes #9653
Summary by CodeRabbit
Release Notes: Version 9.3.0-pre-01
Version Update
Package Updates
Project Template
Miscellaneous