Skip to content

[bitnami/kaniko] #82649 - Added /bin/sh via busybox like googlecontainers-kaniko had to support… #82651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jammsen
Copy link

@jammsen jammsen commented Jun 26, 2025

… gitlab-cicd workflows. Signed-off-by: Sebastian Schmidt [email protected]

Description of the change

Added /bin/sh for GitLab CI/CD usage

Benefits

Now users can use GitLabs before_script to login to custom docker-registries

Possible drawbacks

I dont really now if theese changes will introduce a possible drawback

Applicable issues

Additional information

Please refer to the issue i already created and described the problem im facing - See: #82649

@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@jammsen
Copy link
Author

jammsen commented Jun 27, 2025

Hello @carrodher didnt i do this already? the commit-message has my name and the email from github, because my real would be replaced anyways by github.

Can you please tell me what exactly isnt right?

@carrodher
Copy link
Member

Seems you need to

  1. In your local branch, run: git rebase HEAD~2 --signoff
  2. Force push your changes to overwrite the branch: git push --force-with-lease origin main

jammsen and others added 2 commits June 27, 2025 08:55
… gitlab-cicd workflows.

Signed-off-by: Sebastian Schmidt <[email protected]>
Signed-off-by: Sebastian Schmidt <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Sebastian Schmidt <[email protected]>
@jammsen
Copy link
Author

jammsen commented Jun 27, 2025

Hey @carrodher

Seems you need to

  1. In your local branch, run: git rebase HEAD~2 --signoff
  2. Force push your changes to overwrite the branch: git push --force-with-lease origin main

I had to pull and sync before i can do that, now the release is also signed by me somehow and with 2 emails 😢does that still work for you guys or do i have to delete fork and redo everything?

Sorry for the troubles.

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jun 27, 2025
@github-actions github-actions bot removed the request for review from javsalgar June 27, 2025 14:55
@github-actions github-actions bot requested a review from jotamartos June 27, 2025 14:56
@github-actions github-actions bot removed the triage Triage is needed label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress kaniko verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR - bitnami/kaniko - Please add sh to the kaniko image
5 participants