Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NullPointerException on Android, fixed Swift methods on iOS #260

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zombiQWERTY
Copy link

No description provided.

@zombiQWERTY zombiQWERTY changed the title Fixed NullPointerException on Android, fixed Swift methods Fixed NullPointerException on Android, fixed Swift methods on iOS May 22, 2019
Renamed module from cordova-plugin-qrscanner to cordova-plugin-qrscanner-next
@Yedrup
Copy link

Yedrup commented Jul 31, 2019

Hi !

Any chance to see this PR merged soon ?
I'am facing the NullPointerException too (causing the crash of an android app(made in ionic V3)) and the update of QRScanner.java fixes it.

Thanks @zombiQWERTY for you PR, it's pretty cool!

@zombiQWERTY
Copy link
Author

Hi !

Any chance to see this PR merged soon ?
I'am facing the NullPointerException too (causing the crash of an android app(made in ionic V3)) and the update of QRScanner.java fixes it.

Thanks @zombiQWERTY for you PR, it's pretty cool!

You can simply use my fork on npmjs
https://www.npmjs.com/package/cordova-plugin-qrscanner-next

@Yedrup
Copy link

Yedrup commented Jul 31, 2019

@zombiQWERTY thanks for your answer, that's cool.

I'd rather use the official plugin maintained by bitpay because it's not for a personal project so I have to see long term maintainability and it works great so far.

I hope your pr will be soon merged!

The github repository link on your fork link https://www.npmjs.com/package/cordova-plugin-qrscanner-next returns a 404 by the way

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants