-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infisical-secrets 0.0.2 #4257
base: master
Are you sure you want to change the base?
infisical-secrets 0.0.2 #4257
Conversation
|
Don't forget to follow semantic versioning! Breaking changes (including step inputs) should be in major versions only.
|
I had this same problem with the CLA Assistant when I tried to push this step in December |
Pull secrets from an Infisical secrets repository | ||
description: | | ||
Use this step to access your cloud or self hosted Infisical secrets and inject them into your build pipeline. | ||
website: https://github.com/CodeFishStudio/bitrise-step-infisical-secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL seems to be invalid, I guess the Step repository was renamed to https://github.com/CodeFishStudio/infisical-bitrise-step
.
Please update the website
, source_code_url
, and support_url
fields.
published_at: 2024-08-21T16:31:30.683254+09:30 | ||
source: | ||
git: https://github.com/CodeFishStudio/infisical-bitrise-step.git | ||
commit: ca5df8db8b033c5f7c0d77f3c37c68ae7b7e436a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the 0.0.2
tag points to the [5cbb3a5](https://github.com/CodeFishStudio/infisical-bitrise-step/commit/5cbb3a5b02ae5939db1c49ac7f86bc983c225d4e)
commit in the repository.
Please don't move Step version tags, after you share a Step version.
summary: | | ||
Pull secrets from an Infisical secrets repository | ||
description: | | ||
Use this step to access your cloud or self hosted Infisical secrets and inject them into your build pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: It can be useful to link to the integrated services home page in the Steps description.
description: The client secret is required to authenticate the machine identity | ||
from Infisical | ||
is_expand: true | ||
is_required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensitive inputs should be marked as is_sensitive
: https://devcenter.bitrise.io/en/steps-and-workflows/developing-your-own-bitrise-step/developing-a-new-step.html#sensitive-inputs
Hi @Willt123 I requested some changes, please have a look at them and follow the Fixing issues in a StepLib pull request guide. |
What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.
bitrise run test
(in the step's repository)bitrise run audit-this-step
(in the step's repository - note, if you don't have this workflow in yourbitrise.yml
, you can copy it from the step template.)New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.