Bugfix: Load correct nocublaslt library variant when BNB_CUDA_VERSION override is set #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool, good work! |
matthewdouglas
added a commit
to matthewdouglas/bitsandbytes
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1312
When using
BNB_CUDA_VERSIONin an environment with a compute capability < 7.5, the name of the library that we attempted to load would be incorrect.Before:
BNB_CUDA_VERSION=125tries to loadlibbitsandbytes_cuda125_nocublaslt125.soAfter:
BNB_CUDA_VERSION=125correctly loadslibbitsandbytes_cuda125_nocublaslt.so