Skip to content

Added bvec constructors#528

Merged
bitshifter merged 2 commits intobitshifter:mainfrom
vallentin:bvec-constructors
Jul 7, 2024
Merged

Added bvec constructors#528
bitshifter merged 2 commits intobitshifter:mainfrom
vallentin:bvec-constructors

Conversation

@vallentin
Copy link
Contributor

I noticed that all BVec*s are missing the freestanding fn *vec*() constructors.

@vallentin vallentin force-pushed the bvec-constructors branch from 0568161 to 7387d55 Compare June 20, 2024 03:13
@vallentin
Copy link
Contributor Author

The lint was triggered by a missing cfg attr for scalar-math. Fixed it and rebase.

Copy link
Owner

@bitshifter bitshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have one small request, could you add some test functions? While these are trivial functions it's useful to have tests for code coverage (to see what still needs testing) and also if I ever refactor to make sure I don't miss some functionality.

If you look in tests/vec*.rs there are tests that start with test_mask_, you could either add them to an existing test or add a new one that does something like assert_eq!($mask::new(false, false), $bvec2(false, false))

One catch is you would need to add $bvec2 to the macro signature and pass it through.

@bitshifter bitshifter merged commit 8531717 into bitshifter:main Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants