Added bvec constructors #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vallentin
force-pushed
the
bvec-constructors
branch
from
0568161 to
7387d55
Compare
|
The lint was triggered by a missing cfg attr for |
bitshifter
requested changes
Jun 20, 2024
There was a problem hiding this comment.
Looks good, I have one small request, could you add some test functions? While these are trivial functions it's useful to have tests for code coverage (to see what still needs testing) and also if I ever refactor to make sure I don't miss some functionality.
If you look in tests/vec*.rs there are tests that start with test_mask_, you could either add them to an existing test or add a new one that does something like assert_eq!($mask::new(false, false), $bvec2(false, false))
One catch is you would need to add $bvec2 to the macro signature and pass it through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that all
BVec*s are missing the freestandingfn *vec*()constructors.