[QA-1126] Adding sanity check against real devices for Prod builds #5526
Conversation
This reverts commit 4b2f0da.
|
Great job! No new security vulnerabilities introduced in this pull request |
ifernandezdiaz
force-pushed
the
QA-1126b/adding-native-sanity-test
branch
from
c6058a3 to
62b9088
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5526 +/- ##
=======================================
Coverage 83.86% 83.86%
=======================================
Files 695 698 +3
Lines 52858 52914 +56
Branches 7272 7277 +5
=======================================
+ Hits 44329 44377 +48
- Misses 5985 5991 +6
- Partials 2544 2546 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| implementation(libs.androidx.uiautomator) | ||
| implementation(libs.androidx.espresso.core) | ||
| implementation(libs.androidx.junit.ktx) | ||
| implementation(libs.androidx.ui.test.junit4.android) |
There was a problem hiding this comment.
Can we remove these as implementation dependencies?
There was a problem hiding this comment.
For some reason, the build fails if I remove those dependencies 🤔
There was a problem hiding this comment.
I think he want's them to be an androidTestImplementation to avoid having these test dependencies in the non-test builds
There was a problem hiding this comment.
Yeah, but those deps are already present as androidTestImplementation in lines 302-306.
Apart from that, we need those deps in non-test builds since we aim to test the release build on real devices
There was a problem hiding this comment.
🤔 We do not want to ship with unnecessary dependencies like this. Is there a specific error you are seeing?
There was a problem hiding this comment.
I couldn't find a way to build the required testApp without those deps 🫤
There was a problem hiding this comment.
Maybe we need a new variant for this.
app/src/androidTest/kotlin/e2e/pageObjects/login/EnvironmentSettingsPage.kt
Outdated
Show resolved
Hide resolved
vvolkgang
force-pushed
the
QA-1126b/adding-native-sanity-test
branch
from
1f61ab4 to
a4b464c
Compare
vvolkgang
force-pushed
the
QA-1126b/adding-native-sanity-test
branch
from
a4b464c to
f803752
Compare
ifernandezdiaz
force-pushed
the
QA-1126b/adding-native-sanity-test
branch
from
7d32d32 to
bb8dda4
Compare
| # Keep Kotlin standard library classes | ||
| -keep class kotlin.** { *; } | ||
| -keep class kotlinx.** { *; } | ||
| -keep class kotlin.io.** { *; } |
There was a problem hiding this comment.
Why do we need this?
Are we obfuscating test code?
ifernandezdiaz
force-pushed
the
QA-1126b/adding-native-sanity-test
branch
from
eabd248 to
2cb6a6a
Compare
ifernandezdiaz
force-pushed
the
QA-1126b/adding-native-sanity-test
branch
from
2cb6a6a to
da9b60f
Compare
🎟️ Tracking
📔 Objective
This PR streamlines and enhances our CI/CD pipeline by allowing the execution of sanity checks on real devices in our main build workflow.
It includes all necessary setup, secret retrieval, and artifact management to support E2E testing against real devices using SauceLabs.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes