Skip to content

PM-20152: Remove import logins flow feature flag #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Jul 24, 2025

🎟️ Tracking

PM-20152

📔 Objective

This PR removes the import logins flow feature flat from the app.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront requested review from brian-livefront and a team as code owners July 24, 2025 21:57
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsbf6b2b9a-f315-4a99-8179-ee574c9b04db

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.93%. Comparing base (edd1763) to head (cb0999c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5580      +/-   ##
==========================================
- Coverage   83.94%   83.93%   -0.02%     
==========================================
  Files         699      699              
  Lines       53232    53176      -56     
  Branches     7273     7264       -9     
==========================================
- Hits        44686    44633      -53     
+ Misses       6015     6013       -2     
+ Partials     2531     2530       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit e665c38 Jul 25, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-20152-remove-import-logins-flow-flag branch July 25, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants