Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14859] Fix double prompt when unlocking by ssh request #12000

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Nov 14, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14859

📔 Objective

We were using timeout with the "each" parameter configured instead of "first", leading to multiple prompts. This fixes the behavior.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.44%. Comparing base (a415679) to head (35c18a4).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...desktop/src/platform/services/ssh-agent.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12000   +/-   ##
=======================================
  Coverage   33.44%   33.44%           
=======================================
  Files        2845     2845           
  Lines       89099    89099           
  Branches    16992    16992           
=======================================
  Hits        29803    29803           
  Misses      56950    56950           
  Partials     2346     2346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten marked this pull request as ready for review November 14, 2024 18:07
@quexten quexten requested a review from a team as a code owner November 14, 2024 18:07
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Logo
Checkmarx One – Scan Summary & Detailsd290dec9-e1bb-4aa4-baf9-770b026e0af1

No New Or Fixed Issues Found

@quexten
Copy link
Contributor Author

quexten commented Nov 14, 2024

Merging since the agent is behind a feature flag.

@quexten quexten merged commit 76105aa into main Nov 14, 2024
37 of 38 checks passed
@quexten quexten deleted the km/pm-14859/fix-double-prompt branch November 14, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants