Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13192] [Defect] - Account Security settings not converted to use bit-select #12008

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alec-livefront
Copy link
Collaborator

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13192?atlOrigin=eyJpIjoiNTRiMzdkZjdiNGFiNDk4NWFhNjY3YmQ4ZjZkM2YwN2QiLCJwIjoiaiJ9

๐Ÿ“” Objective

Converts the select on the Account Security Settings page to a bit-select.

๐Ÿ“ธ Screenshots

Screenshot 2024-11-14 at 4 30 08โ€ฏPM

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 33.47%. Comparing base (5c540a8) to head (0fce81a).

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12008      +/-   ##
==========================================
- Coverage   33.48%   33.47%   -0.01%     
==========================================
  Files        2846     2846              
  Lines       89141    89141              
  Branches    16997    16997              
==========================================
- Hits        29849    29842       -7     
- Misses      56945    56952       +7     
  Partials     2347     2347              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ d4c3a8e2-d8d0-4dbb-9f29-83d4bd0d9a0e

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant