Skip to content

Conversation

@cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21097

📔 Objective

This PR resolves an issue where sponsored families created by an organization owner, admin, or custom user with "Manage Users" permission via the Admin Console > Members > Free Bitwarden Families page were incorrectly shown in the individual vault under Settings > Free Bitwarden Families. These entries should only appear in the Admin Console’s Sponsored Families table, not in the admin user’s personal vault interface.

Problem Description:
Currently, when an admin user adds a sponsorship from the Admin Console and the invitee accepts and creates a sponsored organization, that sponsorship is incorrectly shown in two places:

✅ Admin Console > Sponsored Families table (correct)

❌ Vault > Settings > Free Bitwarden Families (incorrect for the admin who added it)

This is misleading because the admin never redeemed the sponsorship for themselves and should not see those orgs in their personal sponsored families list.

📸 Screenshots

Screenshot 2025-05-05 at 13 18 17 Screenshot 2025-05-05 at 13 18 25

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested review from a team as code owners May 5, 2025 12:22
@cyprain-okeke cyprain-okeke requested a review from jrmccannon May 5, 2025 12:22
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.58%. Comparing base (2487e9b) to head (28730b2).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/billing/settings/sponsored-families.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14627   +/-   ##
=======================================
  Coverage   36.58%   36.58%           
=======================================
  Files        3190     3190           
  Lines       92203    92206    +3     
  Branches    16540    16540           
=======================================
+ Hits        33731    33734    +3     
  Misses      56070    56070           
  Partials     2402     2402           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Logo
Checkmarx One – Scan Summary & Detailseb59253e-c3d2-46cd-bb95-ead24861ebe8

Great job, no security vulnerabilities found in this Pull Request

@sonarqubecloud
Copy link

@cyprain-okeke cyprain-okeke merged commit a10b953 into main May 12, 2025
97 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-21097-when-an-org-user-adds-a-sponsorship branch May 12, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants