-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Duo URL redirect enhancements #14640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14640 +/- ##
==========================================
- Coverage 36.39% 36.28% -0.11%
==========================================
Files 3193 3190 -3
Lines 92615 92382 -233
Branches 16669 16601 -68
==========================================
- Hits 33703 33517 -186
+ Misses 56488 56461 -27
+ Partials 2424 2404 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work on these changes. I've got some additional recommendations down below (all tested and work):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
🎟️ Tracking
https://bitwarden.atlassian.net/browse/VULN-241
📔 Objective
As a follow-up to #14174, this provides additional scrutiny to the redirectUrl parameter of the Duo redirect
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes