[PM-21280] - hide setings UI changes behind feature flag

[jaasen-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21280

📔 Objective

This PR hides the nudge epic settings page UI changes behind the feature flag.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 36.25%. Comparing base (11d26a9) to head (428828d).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...pup/settings/about-page/about-page-v2.component.ts	0.00%	4 Missing ⚠️
.../src/tools/popup/settings/settings-v2.component.ts	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14665      +/-   ##
==========================================
- Coverage   36.25%   36.25%   -0.01%     
==========================================
  Files        3193     3193              
  Lines       92432    92440       +8     
  Branches    16603    16605       +2     
==========================================
  Hits        33511    33511              
- Misses      56517    56525       +8     
  Partials     2404     2404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 935e2f7a-ef4d-4ed9-9d86-cf6bc4ec0639

Great job, no security vulnerabilities found in this Pull Request

[Jingo88]

looks good. just some small comments.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jaasen-livefront]

@audreyality If you wouldn't mind taking a quick look when you have a moment it would be greatly appreciated!

[audreyality]

👍🏻 These changes look pretty straightforward to me.

🌱 Deep integration as you do here introduces a lot of churn where the config is added and removed. I'd prefer to isolate the churn within the DI system, where its more easily managed. That would let us control availability by swapping a feature implementation out for a stub that disables it. If you have any ideas on how to use config flags to control dependency injection, let me know!

[jaasen-livefront]

@audreyality Totally agree. I'll definitely give it some thought!