[PM-19976] Implement SDK generator engines #15063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ist.ts Co-authored-by: ✨ Audrey ✨ <[email protected]>
…sword.ts Co-authored-by: ✨ Audrey ✨ <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: ✨ Audrey ✨ <[email protected]>
|
audreyality
requested changes
Jul 1, 2025
libs/tools/generator/core/src/metadata/password/eff-word-list.spec.ts
Outdated
Show resolved
Hide resolved
libs/tools/generator/core/src/metadata/password/eff-word-list.spec.ts
Outdated
Show resolved
Hide resolved
libs/tools/generator/core/src/metadata/password/random-password.spec.ts
Outdated
Show resolved
Hide resolved
libs/tools/generator/core/src/metadata/password/eff-word-list.ts
Outdated
Show resolved
Hide resolved
audreyality
requested changes
Jul 3, 2025
libs/tools/generator/core/src/providers/generator-dependency-provider.ts
Outdated
Show resolved
Hide resolved
libs/tools/generator/components/src/generator-services.module.ts
Outdated
Show resolved
Hide resolved
audreyality
previously approved these changes
Jul 3, 2025
djsmith85
changed the title
audreyality
previously approved these changes
Jul 22, 2025
|
audreyality
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19976
📔 Objective
Hook up new SDK password/passphrase generation engines and put them behind a feature flag.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes