Skip to content

PM-22164 Migrate existing users with "Starts with" and "Regular Expression" set as the global Autofill option to "Base Domain" #15072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented Jun 4, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22164

📔 Objective

When a user has Starts with or regular expression as their default global URI matching strategy, when the user hits the vault view, they will be prompted with a dialog which will not disappear until acknowledged which will set their global setting to Base.

📸 Screenshots

Screen.Recording.2025-06-04.at.10.57.42.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Logo
Checkmarx One – Scan Summary & Details03b57eab-c0e1-466f-865b-4364d2555154

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /apps/web/src/app/dirt/reports/pages/inactive-two-factor-report.component.ts: 131
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
ID: PJlSLvIAgFvf39MBov%2FkpgpnZHo%3D
Attack Vector

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 36.82%. Comparing base (5bd3ab5) to head (e46db67).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lt/popup/components/vault-v2/vault-v2.component.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15072      +/-   ##
==========================================
- Coverage   36.82%   36.82%   -0.01%     
==========================================
  Files        3200     3200              
  Lines       92708    92719      +11     
  Branches    13923    13926       +3     
==========================================
  Hits        34140    34140              
- Misses      57161    57172      +11     
  Partials     1407     1407              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…with-and-regular-expression-set-as-the-global-autofill-option-to-base-domain
…with-and-regular-expression-set-as-the-global-autofill-option-to-base-domain
@dan-livefront dan-livefront requested a review from jprusik June 4, 2025 17:30
Copy link

sonarqubecloud bot commented Jun 4, 2025

@dan-livefront dan-livefront marked this pull request as ready for review June 6, 2025 13:56
@dan-livefront dan-livefront requested a review from a team as a code owner June 6, 2025 13:56
@dan-livefront dan-livefront requested review from shane-melton and a team June 6, 2025 13:56
@dan-livefront dan-livefront marked this pull request as draft June 6, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant