Skip to content

[PM-23663] Update yao-pkg and migrate CLI to Node 22 #15622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dani-garcia
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23663

📔 Objective

Update yao-pkg to the latest audited version, and migrate the CLI to use node 22. This required partial revert of #15058

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dani-garcia dani-garcia force-pushed the ps/PM-23663-update-pkg-node-cli branch from 1b654e0 to cc52138 Compare July 15, 2025 16:42
Copy link
Contributor

github-actions bot commented Jul 15, 2025

Logo
Checkmarx One – Scan Summary & Details8bff5b35-acc0-422c-a601-3f6a49de7fe7

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW Cxda14f253-4e52 Npm-bluebird-3.7.2
detailsDescription: The package `bluebird` is vulnerable to memory leak, when running the function longStackTraces() with the flag `--expose_gc`. This causes a signifi...
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: pz11vfMAes6w5eNtt4namni60%2BRoiI0eNtLs5JRVMS4%3D
Vulnerable Package

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.82%. Comparing base (37987f4) to head (0aaf30f).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15622   +/-   ##
=======================================
  Coverage   37.81%   37.82%           
=======================================
  Files        3299     3299           
  Lines       93962    93962           
  Branches    14248    14248           
=======================================
+ Hits        35536    35543    +7     
+ Misses      56923    56916    -7     
  Partials     1503     1503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dani-garcia dani-garcia marked this pull request as ready for review July 15, 2025 18:14
@dani-garcia dani-garcia requested a review from a team as a code owner July 15, 2025 18:14
@dani-garcia dani-garcia requested a review from addisonbeck July 15, 2025 18:14
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants