-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-23596] Redirect to /setup-extension
#15641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job, no security vulnerabilities found in this Pull Request |
โฆt/pm-23596/redirect-setup-extension
Codecov ReportAttention: Patch coverage is
โ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #15641 +/- ##
==========================================
+ Coverage 37.58% 37.61% +0.03%
==========================================
Files 3320 3321 +1
Lines 94806 94860 +54
Branches 14343 14347 +4
==========================================
+ Hits 35629 35680 +51
- Misses 57681 57683 +2
- Partials 1496 1497 +1 โ View full report in Codecov by Sentry. ๐ New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work! Just wanted to get your thoughts on one comment before approving.
apps/web/src/app/vault/guards/setup-extension-redirect.guard.ts
Outdated
Show resolved
Hide resolved
|
๐๏ธ Tracking
PM-23596
๐ Objective
๐ธ Screenshots
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes