Skip to content

[PM-23596] Redirect to /setup-extension #15641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 23, 2025

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Jul 16, 2025

๐ŸŽŸ๏ธ Tracking

PM-23596

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 16, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 630abc1d-7e61-44c7-bf52-ac179a2e9a9b

Great job, no security vulnerabilities found in this Pull Request

@nick-livefront nick-livefront marked this pull request as ready for review July 17, 2025 15:46
@nick-livefront nick-livefront requested review from a team as code owners July 17, 2025 15:46
@trmartin4 trmartin4 requested review from JaredSnider-Bitwarden and removed request for ike-kottlowski July 17, 2025 15:47
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 37.61%. Comparing base (c379651) to head (39230c5).
Report is 2 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...app/vault/guards/setup-extension-redirect.guard.ts 91.48% 3 Missing and 1 partial โš ๏ธ
apps/web/src/app/oss-routing.module.ts 0.00% 1 Missing โš ๏ธ
...nents/setup-extension/setup-extension.component.ts 92.30% 1 Missing โš ๏ธ
...gistration-finish/registration-finish.component.ts 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15641      +/-   ##
==========================================
+ Coverage   37.58%   37.61%   +0.03%     
==========================================
  Files        3320     3321       +1     
  Lines       94806    94860      +54     
  Branches    14343    14347       +4     
==========================================
+ Hits        35629    35680      +51     
- Misses      57681    57683       +2     
- Partials     1496     1497       +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work! Just wanted to get your thoughts on one comment before approving.

Copy link

@shane-melton shane-melton merged commit 2f47add into main Jul 23, 2025
99 checks passed
@shane-melton shane-melton deleted the vault/pm-23596/redirect-setup-extension branch July 23, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants