Skip to content

Extract utils from common #15689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: extract-serialization-library-from-common
Choose a base branch
from

Conversation

addisonbeck
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 19, 2025

Logo
Checkmarx One – Scan Summary & Detailsd958e89d-6ad9-4f63-b03f-fb707590edfc

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 37.59%. Comparing base (f7e61c2) to head (1b8267d).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/common/src/platform/state/user-key-definition.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                              @@
##           extract-serialization-library-from-common   #15689      +/-   ##
=============================================================================
- Coverage                                      37.59%   37.59%   -0.01%     
=============================================================================
  Files                                           3321     3321              
  Lines                                          94910    94910              
  Branches                                       14359    14359              
=============================================================================
- Hits                                           35682    35678       -4     
- Misses                                         57730    57734       +4     
  Partials                                        1498     1498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addisonbeck addisonbeck force-pushed the extract-utils-from-common branch from 8836e75 to b59ea15 Compare July 23, 2025 18:23
@addisonbeck addisonbeck changed the base branch from main to extract-serialization-library-from-common July 23, 2025 18:25
@addisonbeck addisonbeck force-pushed the extract-utils-from-common branch from b59ea15 to 1b8267d Compare July 23, 2025 18:28
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant