Skip to content

[PM-15847] libs/components strict migration #15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

willmartian
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 24 lines in your changes missing coverage. Please review.

Project coverage is 37.79%. Comparing base (9826f0a) to head (b96e18c).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nents/src/popover/popover-trigger-for.directive.ts 0.00% 8 Missing ⚠️
libs/components/src/input/autofocus.directive.ts 0.00% 3 Missing ⚠️
...mponents/src/async-actions/bit-submit.directive.ts 0.00% 2 Missing ⚠️
...mponents/src/form-field/error-summary.component.ts 0.00% 2 Missing ⚠️
libs/components/src/form-field/error.component.ts 0.00% 2 Missing ⚠️
...mponents/src/async-actions/bit-action.directive.ts 0.00% 1 Missing ⚠️
...src/disclosure/disclosure-trigger-for.directive.ts 0.00% 1 Missing ⚠️
.../components/src/disclosure/disclosure.component.ts 0.00% 1 Missing ⚠️
...ibs/components/src/form-control/label.component.ts 0.00% 0 Missing and 1 partial ⚠️
...ponents/src/tabs/shared/tab-list-item.directive.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15738      +/-   ##
==========================================
- Coverage   37.79%   37.79%   -0.01%     
==========================================
  Files        3300     3300              
  Lines       94003    94017      +14     
  Branches    14255    14260       +5     
==========================================
  Hits        35533    35533              
- Misses      56967    56980      +13     
- Partials     1503     1504       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 22, 2025

Logo
Checkmarx One – Scan Summary & Details784cf523-86c8-41ff-8c85-43f0c85a31dc

Great job, no security vulnerabilities found in this Pull Request

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant